minor cleanup: fixing or silencing flake8 errors#2731
Merged
henryiii merged 3 commits intopybind:masterfrom Dec 19, 2020
Merged
minor cleanup: fixing or silencing flake8 errors#2731henryiii merged 3 commits intopybind:masterfrom
henryiii merged 3 commits intopybind:masterfrom
Conversation
bstaletic
approved these changes
Dec 18, 2020
Collaborator
bstaletic
left a comment
bstaletic
left a comment
There was a problem hiding this comment.
Maybe we should just disable B015? Either way, approved.
Collaborator
Author
|
Thanks @bstaletic ! I'll wait a bit to see if we can get the CI green (waiting for @henryiii's cmake pinning). I think in general B015 is useful. I feel disabling it completely would be a loss, I'd go there only if we had to put in a whole bunch more of the noqa comments. |
bstaletic
reviewed
Dec 18, 2020
henryiii
reviewed
Dec 18, 2020
| assert m.load_vector_via_caster(v2) == 6 | ||
| with pytest.raises(TypeError) as excinfo: | ||
| cm.load_vector_via_binding(v2) == 6 | ||
| cm.load_vector_via_binding(v2) |
Collaborator
There was a problem hiding this comment.
I think B015 helps in cases like this. It clarifies the test is really about the call, and not the comparison, which never happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing errors that appeared after a flake8 version bump.